Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not hardcode scopes for azure AD v2 #279

Merged
merged 3 commits into from
Mar 30, 2023
Merged

fix: do not hardcode scopes for azure AD v2 #279

merged 3 commits into from
Mar 30, 2023

Conversation

JonasKs
Copy link
Member

@JonasKs JonasKs commented Mar 30, 2023

No idea how I didn't see this when I approved.

Added new setting for SCOPES which can be used with v2 tokens.

django_auth_adfs/config.py Outdated Show resolved Hide resolved
@JonasKs
Copy link
Member Author

JonasKs commented Mar 30, 2023

The entire AzureAD tutorial does not work. I'll have to rewrite it entirely. Fixing bugs as I go.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #279 (77aedee) into master (80adc32) will decrease coverage by 0.2%.
The diff coverage is 77.7%.

❗ Current head 77aedee differs from pull request most recent head 1f2dc70. Consider uploading reports for the commit 1f2dc70 to get more accurate results

@@           Coverage Diff            @@
##           master    #279     +/-   ##
========================================
- Coverage    86.3%   86.1%   -0.2%     
========================================
  Files          11      11             
  Lines         549     556      +7     
========================================
+ Hits          474     479      +5     
- Misses         75      77      +2     
Impacted Files Coverage Δ
django_auth_adfs/config.py 87.5% <75.0%> (-0.5%) ⬇️
django_auth_adfs/__init__.py 100.0% <100.0%> (ø)

@JonasKs JonasKs merged commit ed486dc into master Mar 30, 2023
@JonasKs JonasKs deleted the fix_azure_ad branch March 30, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant